search

borglab / wrap

Wrapper generator for C++ projects with multiple language support
Other
30 stars 10 forks source link

Use original name for templated global function #153

Open varunagrawal opened 2 years ago

varunagrawal commented 2 years ago

Fixes #148

varunagrawal commented 2 years ago

True it is API breaking, but it follows with the design @dellaert wants from #148.

As for the second point, that would be the case for the current version of the wrapper as well. double and int is not a good example since they correspond to float and int in python, but functionInt and functionSize_t would still have the same behavior. Plus we already have overloading like this working for the Values class in GTSAM.

ProfFan commented 2 years ago

Overload resolution is tricky and I think what Frank wants (based on our last talk) is we explicitly define these typed overloads in the .i files and leave most overloads automatically resolved. I don't fully agree but it is a reasonable plan.