search

borgmatic-collective / docker-borgmatic

Borgmatic in Docker
GNU General Public License v3.0
354 stars 93 forks source link

Docker tag version and Pip install version #14

Closed j7an closed 5 years ago

j7an commented 5 years ago

Could we specify the Borg version as a variable in the Dockerfile? Then install that specific version in the pip install command? The latest Borg/Borgmatic version may not be the most stable or to some, considered the "safest" as shown in this issue: 1.1.8 has BAD gpg signature on pypi.org

This will allow each build to be tagged and pushed to Docker Hub with the same Borg/Borgmatic version as the pip install. With tagged versions should allow an app like watchtower to automatically install the latest version if a user decides to use the latest tag or just get a notification.

grantbevis commented 5 years ago

Sure submit a PR and I’ll review it

Sent from my iPhone

On 21 Dec 2018, at 16:54, j7an notifications@github.com wrote:

Could we specify the Borg version as a variable in the Dockerfile? Then install that specific version in the pip install command? The latest Borg/Borgmatic version may not be the most stable or to some, considered the "safest" as shown in this issue: 1.1.8 has BAD gpg signature on pypi.org

This will allow each build to be tagged and pushed to Docker Hub with the same Borg/Borgmatic version as the pip install. With tagged versions should allow an app like watchtower to automatically install the latest version if a user decides to use the latest tag or just get a notification.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

toastie89 commented 5 years ago

Updated to latest version #17