boricj / numworks-rpn

RPN calculator for NumWorks
Other
36 stars 11 forks source link

Error with compilation #11

Closed RedGl0w closed 5 years ago

RedGl0w commented 5 years ago

I've tried to compile epsilon 12.0.0 with rpn and it doesn't work The logs :

➜  epsilon git:(master) ✗ sudo make PLATFORM=simulator EPSILON_APPS='rpn settings'
CXX     apps/main.o
In file included from ./apps/rpn/rpn_prompt_controller.h:7:0,
                 from ./apps/rpn/app.h:6,
                 from <command-line>:0:
./apps/rpn/rpn_stack_controller.h:19:7: error: ‘int Rpn::RpnStackController::numberOfRows()’ marked ‘override’, but does not override
   int numberOfRows() override { return m_rpnStack->length(); }
       ^~~~~~~~~~~~
In file included from ./apps/rpn/app.h:6:0,
                 from <command-line>:0:
./apps/rpn/rpn_prompt_controller.h:58:22: error: cannot declare field ‘Rpn::RpnPromptController::m_stackController’ to be of abstract type ‘Rpn::RpnStackController’
   RpnStackController m_stackController;
                      ^~~~~~~~~~~~~~~~~
In file included from ./apps/rpn/rpn_prompt_controller.h:7:0,
                 from ./apps/rpn/app.h:6,
                 from <command-line>:0:
./apps/rpn/rpn_stack_controller.h:11:7: note:   because the following virtual functions are pure within ‘Rpn::RpnStackController’:
 class RpnStackController : public ViewController, public ListViewDataSource, public SelectableTableViewDataSource {
       ^~~~~~~~~~~~~~~~~~
In file included from escher/include/escher/list_view_data_source.h:4:0,
                 from escher/include/escher.h:38,
                 from ./apps/rpn/app.h:4,
                 from <command-line>:0:
escher/include/escher/table_view_data_source.h:9:15: note:  virtual int TableViewDataSource::numberOfRows() const
   virtual int numberOfRows() const = 0;
               ^~~~~~~~~~~~
Makefile:188: recipe for target 'output/simulator/release/apps/main.o' failed
make: *** [output/simulator/release/apps/main.o] Error 1
boricj commented 5 years ago

Ah, the traditional API breakage with a new upstream version of epsilon. I'll look into it.

boricj commented 5 years ago

Should be fixed now against master.