boring12345 / Memory

This is the repository for the Codecademy Memory project.
http://boring12345.github.com/Memory/
11 stars 8 forks source link

Publishing 2.0 #69

Open boring12345 opened 11 years ago

boring12345 commented 11 years ago

I think we only have to update scoring and to add a license, correct? So let's do it. :-)

haxor789 commented 11 years ago

Seems so, maybe I'll find time to look after the license at the weekend.

boring12345 commented 11 years ago

@DaVinniCode

Would you mind to improve scoring?

DaVinniCode commented 11 years ago

I need clear instructions on what you would like done, I know there was a lot of discussion about possibilities, but I wasn't sure what was decided. I am out of town right now, and for another week too and won't have time until I get back home. If either you or haxor want to implement it, that is fine with me. It should be straightforward.

Thanks On Jun 21, 2013 8:15 AM, "boring12345" notifications@github.com wrote:

@DaVinniCode https://github.com/DaVinniCode

Would you mind to improve scoring?

— Reply to this email directly or view it on GitHubhttps://github.com/boring12345/Memory/issues/69#issuecomment-19818233 .

haxor789 commented 11 years ago

I guess for the moment its enought to hide pairs in single player and maybe hide score or just make sure that pairs are the relevant figure in multiplayer, the more advanced scoring system should be for the next version. Anything new from the licence? I didn't managed to get through it this we maybe next days.

boring12345 commented 11 years ago

I think we simply need a basic scoring system in single player, just as we've discussed it here already.

Anything new from the licence?

I didn't have a look at these again, but I will. :-)

haxor789 commented 11 years ago

Ok whats definitly left to be done? attach a GPL3? I guess the scoring systems is ok for the moment its rather simple and we can think of a more complicated later, but for the moment it should be ok.

boring12345 commented 11 years ago

I'd say you make scoring time dependend and I attach a license asap. :-)

boring12345 commented 11 years ago

What do you think about the following sentences:

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.

The Images used in this game are property of Ryzac, Inc. These must not be used for commercial purposes, if they don't allow it,as their Terms of Service say: Intellectual Property. This Agreement does not transfer from Ryzac to you any Ryzac or third party intellectual property, and all right, title and interest in and to such property will remain (as between the parties) solely with Ryzac. Codecademy, Ryzac, Ryzacinc.com, the Website logo, and all other trademarks, service marks, graphics and logos used in connection with the Website are trademarks or registered trademarks of Ryzac or Ryzac licensors. Other trademarks, service marks, graphics and logos used in connection with the Website may be the trademarks of other third parties. Your use of the Website grants you no right or license to reproduce or otherwise use any Ryzac or third-party trademarks. You can reach them here, if you have any questions. We can be reached in the Codecademy AdvancedJavaScriptCoders group, so leave us a note in the group, if you have questions concerning the license.

haxor789 commented 11 years ago

I changed the scoring system, so that you get 10 times points and the score is reduced by 5 every 30 seconds, one might need to adjust these values. In Multiplayer there is no score reduction so far, but atm scores are rather irrelevant anyway to win.

Seems to be ok for the licence, but we should add a COPYRIGHT names years and stuff like this.

boring12345 commented 11 years ago
Copyright (C) This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'. This is free software, and you are welcome to redistribute it under certain conditions; type`show c' for details.

Which name should we add? Should we add this below every file?

haxor789 commented 11 years ago

http://www.gnu.org/licenses/gpl-howto.en.html

Should we add this below every file?

Probably yes, I've seen some where they just added a comment as the header of the file.

boring12345 commented 11 years ago

And what about the name?

boring12345 commented 11 years ago

I changed the scoring system, so that you get 10 times points and the score is reduced by 5 every 30 seconds, one might need to adjust these values. In Multiplayer there is no score reduction so far, but atm scores are rather irrelevant anyway to win.

Awesome! :-)

haxor789 commented 11 years ago

And what about the name?

Mention any contributor by nickname? If possible, we could mention the group as name and seperate credits-like who worked on which part.

boring12345 commented 11 years ago

Mention any contributor by nickname? If possible, we could mention the group as name and seperate credits-like who worked on which part.

Sounds good, so what do you think about

Memory - Client-Side Memory Game Copyright (C) 2013 boring12345, haxor789, DaVinniCode, The Leader of the Codecademy "Advanced JavaScript Coders" group

as the head of our license? (See bottom, to see what I mean.)

haxor789 commented 11 years ago

Looks good, but what the "The Leader of the Codecademy "Advanced JavaScript Coders" group" kind of signature? Maybe leave a line and an indent. Anyway are we ready now?

boring12345 commented 11 years ago

Looks good, but what the "The Leader of the Codecademy "Advanced JavaScript Coders" group" kind of signature? Maybe leave a line and an indent.

Hm, perhaps let's leave it. I thought, if we can't be reached anymore, there should be someone else.

So do I understand it correctly, we should add the following above every file?

Memory - Client-Side Memory Game
Copyright (C) 2013 boring12345, haxor789, DaVinniCode,
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see http://www.gnu.org/licenses/.

The Images used in this game are property of Ryzac, Inc.
These must not be used for commercial purposes,
if they don't allow it,as their Terms of Service say:
> Intellectual Property. This Agreement does not transfer from Ryzac to you any Ryzac or third party intellectual property, and all right, title and interest in and to such property will remain (as between the parties) solely with Ryzac. Codecademy, Ryzac, Ryzacinc.com, the Website logo, and all other trademarks, service marks, graphics and logos used in connection with the Website are trademarks or registered trademarks of Ryzac or Ryzac licensors. Other trademarks, service marks, graphics and logos used in connection with the Website may be the trademarks of other third parties. Your use of the Website grants you no right or license to reproduce or otherwise use any Ryzac or third-party trademarks.

You can reach them here, if you have any questions.
We can be reached in the Codecademy AdvancedJavaScriptCoders group, so leave us a note in the group, if you have questions concerning the license.
DaVinniCode commented 11 years ago

Thanks for doing all this guys! Sorry I haven't been able to help. Have been working a lot, and traveling. Hope you both are having a good summer. On Jul 26, 2013 12:23 PM, "boring12345" notifications@github.com wrote:

Looks good, but what the "The Leader of the Codecademy "Advanced JavaScript Coders" group" kind of signature? Maybe leave a line and an indent.

Hm, perhaps let's leave it. I thought, if we can't be reached anymore, there should be someone else.

So do I understand it correctly, we should add the following above every file?

Memory - Client-Side Memory Game Copyright (C) 2013 boring12345, haxor789, DaVinniCode, This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/.

The Images used in this game are property of Ryzac, Inc. These must not be used for commercial purposes, if they don't allow it,as their Terms of Service say: Intellectual Property. This Agreement does not transfer from Ryzac to you any Ryzac or third party intellectual property, and all right, title and interest in and to such property will remain (as between the parties) solely with Ryzac. Codecademy, Ryzac, Ryzacinc.com, the Website logo, and all other trademarks, service marks, graphics and logos used in connection with the Website are trademarks or registered trademarks of Ryzac or Ryzac licensors. Other trademarks, service marks, graphics and logos used in connection with the Website may be the trademarks of other third parties. Your use of the Website grants you no right or license to reproduce or otherwise use any Ryzac or third-party trademarks. You can reach them here, if you have any questions. We can be reached in the Codecademy AdvancedJavaScriptCoders group, so leave us a note in the group, if you have questions concerning the license.

— Reply to this email directly or view it on GitHubhttps://github.com/boring12345/Memory/issues/69#issuecomment-21638820 .

boring12345 commented 11 years ago

I think, when we know, whether we should add the linked text above every file, we can go through our project again searching for unnecessary/bad code and then we're ready to publish it (finally). I hope we're able to do this this sunday. :-)

boring12345 commented 11 years ago

@haxor789 Have you completed everything you wanted to do?

Should we release the version first or shall I try to remove the global variables first? PS: Should I add the linked text above every file?

haxor789 commented 11 years ago

Sry completly missed this post :-( This week im going to a festival, so I wont have much time to change anything, If you want to change something, do it. I'll have a look at it in the change history. Maybe we could wrap them in the onload scope.

Should I add the linked text above every file?

According to the how-to link that seem to be necessary.

boring12345 commented 11 years ago

I know this is an old discussion, but what do you think about publishing the new version without a license? If you agree, I will do it as soon as possible. :-)

haxor789 commented 11 years ago

I agree, maybe we could add a licence like: "Use it for free for fun but not for comercial use" or something like this in the readme. Anyway it should get published :-)

DaVinniCode commented 11 years ago

I loaded up github a month or two ago and tried the latest beta out, and it seems like when I pick an AI player, it won't take turns when it is supposed to. I didn't really try debugging it, but hopefully it's an easy fix. I had to go way back in changes before I got a working version.

Are either of you having the same problem? Maybe mine is just messed up!

On Mon, Oct 21, 2013 at 4:51 PM, haxor789 notifications@github.com wrote:

I agree, maybe we could add a licence like: "Use it for free for fun but not for comercial use" or something like this in the readme. Anyway it should get published :-)

— Reply to this email directly or view it on GitHubhttps://github.com/boring12345/Memory/issues/69#issuecomment-26763928 .

boring12345 commented 11 years ago

I agree, maybe we could add a licence like: "Use it for free for fun but not for comercial use" or something like this in the readme. Anyway it should get published :-)

Yes, please do so. I think I'd forget it again.

I loaded up github a month or two ago and tried the latest beta out, and it seems like when I pick an AI player, it won't take turns when it is supposed to.

Unfortunately you are right, the AI does not do, what it is supposed to do. :-(

haxor789 commented 11 years ago

I'll have a look at it at the weekend.

boring12345 commented 11 years ago

Let's publish it by sunday. :-)

haxor789 commented 11 years ago

Ok. The AI should be fixed now or is their another bug?

boring12345 commented 11 years ago

I don't think so. Perhaps we could add a message, if someone presses "Start" without having chosen any players. However, I can't see real bugs. :-) Shall I push the files to master? When publishing our game, do you think we will continue improving our game (i.e. by searching for someone, who redesigns the background) or shall I announce this version as the final version?

haxor789 commented 11 years ago

Yes You can push it to master, I'll have a look at the Start message soon. Well I'd like to continue improving it, I just don't know if I'll have the time to do so.

btw: Isn't gh-pages the playable one?

boring12345 commented 11 years ago

Okay, it is online, but not published, as I want to know, whether is still has bugs. :-)

boring12345 commented 11 years ago

I'll create a new thread dealing with our game at CC soon. :-)