search

boris-kz / CogAlg

This project is a Computer Vision implementation of general hierarchical pattern discovery principles introduced in README
http://www.cognitivealgorithm.info
MIT License
90 stars 42 forks source link

form_rooted_blob, form_multy_blob; mblob, mBlob - or whatever - instead of form_Blob, Blob #11

Closed Twenkid closed 3 years ago

Twenkid commented 5 years ago

It's confusing memory and breaks the naming convention of the functions. Yes, for a 300-line long code and functions which are next to each other it's not that critical, but in general it's a bad style, and is making search harder when studying the code.

I know it's applied for other variables, but in the other cases it's logically more coherent - single values, aggregated, ... or they reflect significantly different matters like p and P.

https://github.com/boris-kz/CogAlg/blob/9fa47a929ae39acb1d23dd357a7412c3d28f0a45/frame_dblobs.py#L216

boris-kz commented 5 years ago

Yeah... I just changed blob to seg (blob segment) and Blob to blob, that's more suggestive.

On Mon, Sep 24, 2018 at 8:03 PM Todor Arnaudov notifications@github.com wrote:

It's confusing memory and breaks the naming convention of the functions. Yes, for a 300-line long code and functions which are next to each other it's not that critical, but in general it's a bad style, and is making search harder when studying the code.

I know it's applied for other variables, but in the other cases it's logically more coherent - single values, aggregated, ... or they reflect significantly different matter like p and P.

https://github.com/boris-kz/CogAlg/blob/9fa47a929ae39acb1d23dd357a7412c3d28f0a45/frame_dblobs.py#L216

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/boris-kz/CogAlg/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AUAXGahwPeesSVnP25-6VS-G0JY-BD3jks5ueXLlgaJpZM4W3pp8 .