boris-kz / CogAlg

This project is a Computer Vision implementation of general hierarchical pattern discovery principles introduced in README
http://www.cognitivealgorithm.info
MIT License
90 stars 42 forks source link

Removed empty comp_ders [] in min_rng ders. Changes are made around line 44 and 90 (in new file) #15

Closed khanh93vn closed 5 years ago

boris-kz commented 5 years ago

if P[5]: ip = e_[i][0][0] (pri_ip, i_d, i_m), inputders = prie else: ip = e[i][0] (pri_ip, i_d, i_m), inputders = pri_e, [] ?

khanh93vn commented 5 years ago

-About using r instead of compders: I added a breakpoint on line 99 with the condition: compders and r == 0. The debugger stopped at that breakpoint more than once, meaning that there are cases where r = 0 while compders is not empty. Or do you mean that when r = 0, adding compders is not neccessary anymore?

-About P[5]: If comders is added according to r as mentioned above then this should be correct, I guess