search

borisbrodski / Jnario

Executable specifications for Java
jnario.org
3 stars 4 forks source link

No Storage resources #6

Closed ghaith closed 8 years ago

ghaith commented 8 years ago

Disabled the new load from storage behaviour for Jnario as some suite generation code was relying on the symentic model which is no longer provided if the resource is loaded from storage. I added a NO_XTEND todo note to this because I believe a better fix would be to avoid the NodeModel all together

borisbrodski commented 8 years ago

Cool, thank you!

Just one thing: chould you please avoid formatting code (and especially comments). You changed just a couple of lines in each module, but the diff contains 152 lines!

Could you remove those formatting changes easily? If no, I will merge it as it is.

ghaith commented 8 years ago

I'll send in a new commit with the formatting removed, sorry about that we have automatic formatting rules in our eclipse setups that i forgot to disable for Jnario

borisbrodski commented 8 years ago

Great! Thank you!

ghaith commented 8 years ago

OK, I sent in an new commit with the same title, so this pull request should have the new code I believe

borisbrodski commented 8 years ago

Yes, it works :) Cool.