Throttle and brake have negative values

borisdayma / CarND-Capstone

Programming a self-driving car

3 stars 4 forks source link

Throttle and brake have negative values #17

Closed borisdayma closed 6 years ago

borisdayma commented 6 years ago

Throttle and brake have sometimes negative values, which should not be possible.

taikione commented 6 years ago

You can change minimum output value of PID. Please check this launch file.

borisdayma commented 6 years ago

I think "decel_limit" is related to max brake. But the min of throttle and brake should probably be 0, meaning that they are not engaged at all. So we would have:

throttle needs to be between 0 and accel_limit
brake needs to be between 0 and -decel_limit What do you think?

taikione commented 6 years ago

I entirely agree with you.

This is nice!

brake needs to be between 0 and -decel_limit