borismus / keysocket

http://smus.com/chrome-media-keys-revisited
Apache License 2.0
382 stars 164 forks source link

Audio Station on Synology DSM 6 doesn't work #173

Open alexteg opened 8 years ago

alexteg commented 8 years ago

keysocket doesn't seem to inject itself into pages running Synology DSM 6. The manifest currently only captures pages containing "*://*/webman/*", while DSM no longer has webman in the URL and redirects any access to that URL to just index.cgi, which also may be omitted. The DSM can now be loaded with the bare domain + port that it resides on, such as https://foobar.synology.me:5001/ without any additional path, which considering the domain & port is adjustable makes it difficult to capture all possible URL combinations.

eguilder commented 8 years ago

Just make it capture pages on ports 5000/5001 that should be good enough

feedbee commented 7 years ago

Is it still actual problem? Can we catch https://*.synology.me/*?

feedbee commented 7 years ago

Demo version of DSM is running at https://***.demo.synology.com:5001/. So, to catch https://*.synology.me/* is not a solution. While we know nothing about domain, we can't detect the site.

There are different variants to handle this problem, but all of them have weaknesses: 1) Check all sites for some condition to detect DSM. - Resources waste for all extension users on all sites for this check. 2) Give extension user a tool to set custom domain for plugin. - We need to build options window, which is absent currently. 3) Give extension user a tool to set custom handler for custom domain: more general solution, but still - We need the window.

I think we have to leave this issue opened as feature request for custom configuration.

wzooff commented 7 years ago

One more solution. Works for me, when i've set "audiostation" as an alias

audiostation

And now i can open Audio Station as separate tab in browser if type in url field https://mysyno.com/audiostation/

UPD works with current version of websocket if use "audio"

feedbee commented 7 years ago

Thank you, @wzooff. But It's still a workaround, not a reliable and straightforward solution.

wzooff commented 7 years ago

Yep, but its mostly synology owners problem, than keysocket. In keysocket readme we see "when you're listening to music on various streaming websites" and keysocket has list of supported websites (without dsm v6). It's by design. Synology NAS is not a streaming website. For me its not a problem to configure alias :) maybe we need amend documentation or create FAQ/remark for DSM6

Or better to extend feature request and create configuration page (solution #3)

eguilder commented 7 years ago

I tried wzooff's solution and it didn't work:

  1. have audio station running on: http://192.168.192.69:5000/audiostation/
  2. I edited the manifest.json to have: { "js": [ "shared.js", "keysocket-synology.js" ], "matches": [ ":///webman/", "://*/audiostation/" ] }

But the extension doesn't get enabled when I am on the audio station URL. What could be wrong?

Update: fixed it by packing. removing and re-installing the extension!