borismus / webvr-boilerplate

A starting point for web-based VR experiences that work on all VR headsets.
Apache License 2.0
1.8k stars 451 forks source link

add `node_modules` to `.gitignore` #123

Closed cvan closed 8 years ago

borismus commented 8 years ago

Why? Kinda nice to be able to just run the thing from checkout, isn't it?

cvan commented 8 years ago

Why? Kinda nice to be able to just run the thing from checkout, isn't it?

if it's up to date, yeah. it's a lot of noise, and it can be difficult when going to revisions in the past, if the modules weren't updated correctly. if you want to keep them checked in, that's fine. most npm projects I've seen stop doing that. whatever's easiest for users/devs I suppose.

borismus commented 8 years ago

I prefer to keep as is for now.

cvan commented 8 years ago

okay, that's fine