search

borismus / webvr-boilerplate

A starting point for web-based VR experiences that work on all VR headsets.
Apache License 2.0
1.8k stars 451 forks source link

Fix desktop VR compatibility #139

Closed brianpeiris closed 8 years ago

borismus commented 8 years ago

Thanks, Could you explain what this is fixing?

On Wed, May 4, 2016, 1:36 AM Brian Peiris notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/borismus/webvr-boilerplate/pull/139 Commit Summary

  • Fix desktop VR compatibility

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/borismus/webvr-boilerplate/pull/139

pindiespace commented 8 years ago

Well, my own take on this is there should be an option to do stereo view on desktop, instead of automatically locking you to fullscreen on desktop. Not only is it helpful to develop apps, but there are many situations (e.g. presentation to a group of people) where showing the stereo view from the laptop would be very helpful. Not everyone in the audience is going to have a headset or smartphone, and just showing a 3D scene doesn't help understanding when marketing the WebVR concept.

brianpeiris commented 8 years ago

Without this fix you can't enter VR mode in the latest Chromium WebVR build. The VR button doesn't show at all.

borismus commented 8 years ago

Thanks for the PR. The real solution is here, will be merged into master soon (as soon as I've tested stage parameters on Vive): https://github.com/borismus/webvr-boilerplate/commit/a54f0459a6aec7858d06817db38ec9cbcb804b27

brianpeiris commented 8 years ago

Gotcha, thanks. I'll close this one.