search

borismus / webvr-boilerplate

A starting point for web-based VR experiences that work on all VR headsets.
Apache License 2.0
1.8k stars 451 forks source link

Button Position: Why `position: fixed;` #147

Closed Fischaela closed 8 years ago

Fischaela commented 8 years ago

Hey,

I just have a short question: Why are the buttons placed with position: fixed;? Wouldn't it be slightly better to use position: absolute;, so the buttons will be aligned relative to the parent element's dimensions? What are the downsides, am I overlooking something?

Cheers, Michaela

bildschirmfoto_2016-06-21_um_15_35_31

borismus commented 8 years ago

I think you're right. Especially if the canvas is not full screen. I'm open to PRs.

On Tue, Jun 21, 2016 at 6:37 AM Michaela notifications@github.com wrote:

Hey,

I just have a short question: Why are the buttons placed with position: fixed;? Wouldn't it be slightly better to use position: absolute;, so the buttons will be aligned relative to the parent element's dimensions? What are the downsides, am I overlooking something?

Cheers, Michaela

[image: bildschirmfoto_2016-06-21_um_15_35_31] https://cloud.githubusercontent.com/assets/3409561/16231322/0427ac9c-37c6-11e6-8d9d-8460ff9c705f.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/borismus/webvr-boilerplate/issues/147, or mute the thread https://github.com/notifications/unsubscribe/AAQ8gHqqlyRTphrLAYGx0laVAZ27tjoQks5qN-kngaJpZM4I6vgZ .

Fischaela commented 8 years ago

Submitted PR #148