borisyankov / react-sparklines

Beautiful and expressive Sparklines React component
MIT License
2.84k stars 194 forks source link

1.7.0 release raises error #89

Open ZakSingh opened 7 years ago

ZakSingh commented 7 years ago

As of today's release, the module fails to import in a React Redux Webpack setup using this boilerplate from the "Modern React with Redux" tutorial on Udemy. It results in: Uncaught TypeError: Super expression must either be null or a function, not undefined

This is my first time using React, Redux, and your module, so I have no idea what I'm talking about in terms of troubleshooting. I just reverted the package to 1.6.0 and it fixed the issue.

ricardovalquin commented 7 years ago

Hi @ZakSingh , I'm having the same issue, can you tell me please how to revert the version of the package? I just modify my package.json to that version and re installed everything again but doesn't works thank you

soymanuvalle commented 7 years ago

@ricardovalquin Hola Ricardo, puedes hacerlo con los siguientes comandos desde tu consola:

npm r react-sparklines npm i --save react-sparklines@1.6.0

Cambia 1.6.0 por la versión que deseas instalar. Si el problema persiste utiliza la versión 1.4.0. Saludos!

borisyankov commented 7 years ago

I will look into it and release a fix.

abdennour commented 7 years ago

As of August 2017, the author of this library accidentally deployed a broken build, specifically version 1.7.0. As such, we want to avoid that build. So when we install the react-sparklines package, run this command

npm i --save react-sparklines@1.6.0

This will install version 1.6.0, which doesn't have the broken code.

IamManchanda commented 6 years ago

@abdennour Nah I will run yarn add react-sparklines@1.6.0 :wink:

nbkhope commented 6 years ago

Has the development of react-sparklines come to a halt? Since nobody seems to care about fixing the latest release that is broken.

AbhinJ commented 6 years ago

This issues is resolved after releasing of React v16.3.2 . React sparklines 1.7.0 worked for me . So, issue should be closed

shachopin commented 5 years ago

still same issue for 1.7.0 as for today had to downgrade