search

borkdominik / bigER

Entity Relationship Diagram modeling tool realized as a language server that is distributed as a VS Code extension.
https://marketplace.visualstudio.com/items?itemName=BIGModelingTools.erdiagram
MIT License
106 stars 13 forks source link

Edges are incorrectly updated after changing notation #19

Closed Aksem closed 2 years ago

Aksem commented 2 years ago

How to reproduce: change notation from 'Default' to 'Bachman' and back.

What is wrong: edges are either incorrect or even invisible. After moving a diagram element that forces edge update, they are correct again.

Incorrect after changing: grafik

Correct after force update: grafik

Aksem commented 2 years ago

Found the reason and described in adaptagrams issue: https://github.com/Aksem/adaptagrams/issues/11

Briefly about the problem: after changing the notation, old edges are removed, and new ones with the new notation are created. If new edges are created first and only after that the old ones are removed, libavoid doesn't update edges, and they look so as if there are both new and old edges.

Fixed in adaptagrams: https://github.com/Aksem/adaptagrams/pull/12 And released new libavoid-js, sprotty-routing-libavoid and updated them in bigER.