search

borkdude / deps.clj

A faithful port of the clojure CLI bash script to Clojure
Eclipse Public License 1.0
256 stars 20 forks source link

Consider using XDG specification for the default location of DEPS_CLJ_TOOLS_DIR #126

Open bigodel opened 6 months ago

bigodel commented 6 months ago

Instead of relying on ~/.deps.clj/..., consider using e.g. XDG_STATE_HOME, which defaults to ~/.local/state, in order to comply to XDG Base Directory Specification.

borkdude commented 6 months ago

Sure, I welcome a PR for this

borkdude commented 6 months ago

I'm not sure if XDG_STATE_HOME should be used for this however. This seems to be for log/history files. The tools dir is part of the installation.

borkdude commented 6 months ago

bbin seems to use XDG_DATA_HOME for this: https://github.com/search?q=repo%3Ababashka%2Fbbin%20XDG&type=code

bigodel commented 6 months ago

Sure, I welcome a PR for this

All right, seems simple enough that I could create a PR myself, I just might take a few days to get it done because I've been pretty busy. I'll use bbin's implementation as a reference.

bigodel commented 6 months ago

I'm not sure if XDG_STATE_HOME should be used for this however. This seems to be for log/history files. The tools dir is part of the installation.

Yeah, you're right, my mistake. XDG_DATA_HOME would be more appropriate indeed.