search

borkdude / flycheck-clj-kondo

Emacs integration for clj-kondo via flycheck
94 stars 17 forks source link

Run scoop as admin, add Emacs 28.1 to CI tests #22

Closed ikappaki closed 2 years ago

ikappaki commented 2 years ago

Could you please review patch, to pass Admin flag to Scoop, used for the clj-kondo installation, since it is now explicitly required when installed as Admin (as in the case of CI runs #21) .

Also added Emacs 28 in the test matrix, and moved the snapshot version to only be run for ubuntu builds (I find it a waste of resources and time to run it for all three architectures, one should be indicative.

The tests should pass once #20 is committed.

Thanks

borkdude commented 2 years ago

I merged #20, should we update this PR with it?

ikappaki commented 2 years ago

I merged #20, should we update this PR with it?

Merged, but the scoop installation script appears to have just got an interim issue https://github.com/ScoopInstaller/Scoop/issues/4917 that fails the scoop installation just at the start:

Adding ~\scoop\shims to your path.
Scoop was installed successfully!
Type 'scoop help' for instructions.
Convert-RepositoryUri: C:\Users\runneradmin\scoop\apps\scoop\current\lib\buckets.ps1:165
Line |
 165 |          if ((Convert-RepositoryUri -Uri $remote) -eq $uni_repo) {
     |                                          ~~~~~~~
     | Cannot bind argument to parameter 'Uri' because it is an empty string.

although there is a workaround that I've tested it to work (remove and readd the main bucket), I'd rather wait for the above scoop problem to be fixed upstream before committing this one if you don't mind :)

Thanks

ikappaki commented 2 years ago

Hi @borkdude,

the scoop installer fix has just been released upstream. Would you be able to re-trigger the CI tests for this PR? All tests should complete successfully now.

Thanks

borkdude commented 2 years ago

Done, works fine now!