search

borkdude / grasp

Grep Clojure code using clojure.spec regexes
Eclipse Public License 1.0
242 stars 7 forks source link

Turn valid-fn into keep-fn to allow recording more info #25

Closed mk closed 2 years ago

mk commented 2 years ago

And show how to use it in example. Like shown in table-row it's fine to conform a resulting expression again but without a change like this I could not get the resolved var name because grasp/resolve-symbol depends on the *ctx* binding.

Closes #26.

borkdude commented 2 years ago

Can you first post an issue with the problem statement? Then we can mention the issue number in the PR message. I haven't set up the dev workflow explicitly for this project, but assume it is the same as babashka: https://github.com/babashka/babashka/blob/master/doc/dev.md#start-with-an-issue-before-writing-code

I'll make that explicit now.

borkdude commented 2 years ago

In addition to describing the issue in an issue, can you also add a test that demonstrates the issue that this PR fixes?

mk commented 2 years ago

@borkdude added the test in d137b4aae59b1c25255e7c665d63a2cef3f56b6e and #26 hopefully describes the issue.