search

borkdude / quickblog

Light-weight static blog engine for Clojure and babashka
https://blog.michielborkent.nl/
MIT License
165 stars 28 forks source link

Default tag `clojure` added automatically without ability to change or have no tags at all #51

Closed formsandlines closed 1 year ago

formsandlines commented 1 year ago

In the latest commit, while the --tags option for quickblog new is not required anymore, the default tag clojure is still added automatically. I would prefer to be able to specify a different default tag or none at all, if desired.

@borkdude suggested introducing a :default-tags option, which I think is a good idea. I guess setting this to an empty vector could get rid of the Tags: … field in .md files entirely or just leave it empty.

borkdude commented 1 year ago

Sounds good. cc @jmglov

formsandlines commented 1 year ago

I just made a PR on this issue (actually my first-ever, so I hope everything is fine :)): https://github.com/borkdude/quickblog/pull/52

“Tagged:” will still appear in the HTML output, maybe it could be removed if there are no tags, but I wasn’t sure how to check for an empty collection in the template language ({% if tags %} didn’t seem to work).

borkdude commented 1 year ago

@formsandlines I added a test runner on CI now. I noticed there were some flaky tests and I disabled those. Can you merge the main branch into your PR so your PR will run the tests automatically as well? Then I'll look at the rest of your PR.

borkdude commented 1 year ago

Updated the PR via the Github UI