search

borkdude / speculative

Unofficial community-driven specs for clojure.core
Eclipse Public License 1.0
188 stars 16 forks source link

into #172

Closed bonega closed 5 years ago

borkdude commented 5 years ago

@bonega Thanks! Could you add a test for every arity? Also, it would be nice to add a check, so it does generative testing in addition to the example based tests.

bonega commented 5 years ago

@borkdude sure, pushed now. The js-tests are a bit finicky regarding clean.

borkdude commented 5 years ago

@bonega yes, they are very sensitive. maybe I should just add a clean to the test script. there is some discussion about the types or arguments on Slack (#speculative). ::ss/seqable may have to be ::ss/reducible-coll instead.

borkdude commented 5 years ago

@bonega One more enhancement: can you make a ::coll spec in specs.cljc and use that in into? We have the convention to use keywords instead of predicates. See: https://github.com/slipset/speculative/blob/master/doc/style.md

bonega commented 5 years ago

@borkdude sorry, was taking a break. Will check style doc for next PR.

borkdude commented 5 years ago

np, it was only a minor detail that was easy to fix. thanks for your contribution! it's now visible at: https://re-find.it/?args=%5B1%202%203%5D%20%5B4%205%206%5D&ret=%5B1%202%203%204%205%206%5D&exact=true