search

borkdude / tools

Tools
19 stars 2 forks source link

lein2deps: add :compile-path to :paths when present #3

Closed DerGuteMoritz closed 1 year ago

DerGuteMoritz commented 1 year ago

This is necessary for making things work when a Leiningen project comes with some Java sources, for example (like Aleph :smile:). Note that this doesn't account for when project.clj relies on the default :compile-path. This is in line with how lein2deps treats :source-paths which happens to work fine because the default appears to be the same for both deps.edn and project.clj. Maybe we should account for this here? Then again, most projects probably don't need :compile-path so always including the default seems annoying, too. Instead, people could just be advised to add it explicitly to their project.clj even if it means repeating the default. WDYT?

borkdude commented 1 year ago

Thanks!

borkdude commented 1 year ago

Haha, sorry, I read your message too late. I think this is probably fine as it is now.

DerGuteMoritz commented 1 year ago

No problem, thanks for merging :smile: