search

borkdude / tools

Tools
19 stars 2 forks source link

lein2deps: add javac prep lib support #5

Closed DerGuteMoritz closed 1 year ago

DerGuteMoritz commented 1 year ago

Fixes #4.

borkdude commented 1 year ago

Fantastic :)

borkdude commented 1 year ago

Btw, I don't think :compile-path is mandatory in project.clj for Java compilation to happen

DerGuteMoritz commented 1 year ago

Btw, I don't think :compile-path is mandatory in project.clj for Java compilation to happen

That's correct but without adding it to :paths in deps.edn, the class files would not be picked up by tools.deps. And as discussed in https://github.com/borkdude/tools/pull/3, we're currently not filling in the default :compile-path when it's not set. I guess we should either document that it's required to explicitly specify both :java-source-paths and :compile-path for using this feature or we could fill in the default :compile-path of target/classes if only :java-source-paths is given. WDYT?

borkdude commented 1 year ago

I think filling in the default :compile-path would make lein2deps less surprising?