borkshop / kni

An interactive story language in JavaScript inspired by Inkle’s Ink
MIT License
80 stars 10 forks source link

Modernization #15

Open jcorbin opened 3 years ago

jcorbin commented 3 years ago
jcorbin commented 3 years ago

Update: istanbul's use of esprima blocks #21 similarly to eslint's parser issues; will update to nyc next, and sort out it's parsing deal

kriskowal commented 3 years ago

pop-equals could probably be inline or simplified. It’s one of my own dead-ends.

tee could probably be inlined and simplified. Just need an object that forwards to two.

shon is also an ill-advised kris special but one I like if you’re up for lifting it upstream.

jcorbin commented 3 years ago

Updated now that we're past the eslint:recommended gate

Next step is a side quest for kni.js test coverage, as revealed by the latent bug discovered in #37

Considering doing a patch release for v3 and v4 including that fix plus the ceil/round bugs fixed in #17

jcorbin commented 3 years ago

Also will probably drop all the // istanbul ignore ... comments, and track towards enabling "all sources" mode to make our coverage numbers more honest as speculated in #34.