kni: paper over lint error, with a FIXME note

borkshop / kni

An interactive story language in JavaScript inspired by Inkle’s Ink

MIT License

80 stars 10 forks source link

Closed jcorbin closed 3 years ago

jcorbin commented 3 years ago

Typo causes an unused var lint under eslint:recommended gate towards #15

But not sure what the right way to fix it is, since am a little unclear on the intended use case.

Ideally, this would be added as a missing / failing test, and then fixed; maybe @kriskowal can hum me a few bars of what that test would do?

Barring that, if this ends up being the last thing holding back eslint:recommended, will just land as this paper thin "fix".

jcorbin commented 3 years ago

Pivoted to a minimal actual fix; TODO test coverage being pursued in #48