borni-dhifi / vatnumber

Automatically exported from code.google.com/p/vatnumber
GNU General Public License v3.0
0 stars 0 forks source link

Turkey VAT Number #21

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Can you add to the code.. For Turkey it is 1 digits.

    ('TR', '1234567890', True),

Thank you..

Original issue reported on code.google.com by erdemu...@gmail.com on 29 Feb 2012 at 8:15

GoogleCodeExporter commented 8 years ago
well it is 10 digits from each digit can be 0-9. I don't know if I pasted a 
correct form. =)

Original comment by erdemu...@gmail.com on 29 Feb 2012 at 8:41

GoogleCodeExporter commented 8 years ago
What is the validation rule?

Original comment by cedric.krier@b2ck.com on 29 Feb 2012 at 11:27

GoogleCodeExporter commented 8 years ago
There is no validation. I have checked with a person who is the head of a 
regional tax office in Turkey. He said that there is no validation, the system 
gives the next available number. Only thing is that they have previously 
divided the numbers so that, if the company name starts with A the number 
starts with 0, if it is B it starts with 1, if it is Y or Z it starts with 9, 
etc. So there is no validation in your system that would work. Just 10 digits, 
without any letters any digit can be between 0 and 9.

Also, It may not be related to you but OpenERP is using this script and it 
gives the below error, when I edit the VAT number of a Turkish company.

ValidateErrorError occurred while validating the field(s) vat:This VAT number 
does not seem to be valid.Note: the expected format is 'CC##' (CC=Country Code, 
##=VAT Number)

It seems a script error but I assume this may return because there is no CC=TR 
defined in your script. I believe if you can add an option that if the CC is 
not in the list anything should be valid. That would be great.

Original comment by erdemu...@gmail.com on 29 Feb 2012 at 2:33

GoogleCodeExporter commented 8 years ago
As you say there is no validation so I don't see why we should include code 
that does nothing.
You should ask OpenERP to fix their code to not try to validate something that 
doesn't require validation.

Original comment by cedric.krier@b2ck.com on 29 Feb 2012 at 3:07

GoogleCodeExporter commented 8 years ago
You can validate if it is 10 digits and it is all numbers.

Original comment by erdemu...@gmail.com on 29 Feb 2012 at 3:13

GoogleCodeExporter commented 8 years ago
Ok, so you can submit a patch

Original comment by cedric.krier@b2ck.com on 16 Apr 2012 at 6:55

GoogleCodeExporter commented 8 years ago

Original comment by cedric.krier@b2ck.com on 8 Nov 2012 at 11:35

GoogleCodeExporter commented 8 years ago
I have done the patch for Turkish VAT number. I am attaching the patch.

Original comment by erdemu...@gmail.com on 7 Jan 2013 at 8:51

Attachments:

GoogleCodeExporter commented 8 years ago
vatnumber uses now python-stdnum, so new validation should be first proposed 
there.

Original comment by cedric.krier@b2ck.com on 3 Apr 2014 at 7:42

GoogleCodeExporter commented 8 years ago

Original comment by cedric.krier@b2ck.com on 3 Apr 2014 at 7:43