OSX: breakpad rejects valid modules with a vmaddr of zero

[GoogleCodeExporter]

I came across this while preparing Firefox with breakad: when we compile
.dylibs, they are not rebased, so they have a vmaddr of zero. This means
that the IsValid check in dynamic_images.h fails. This can be fixed with a
simple patch:

Index: src/client/mac/handler/dynamic_images.h
===================================================================
RCS file:
/cvsroot/mozilla/toolkit/airbag/airbag/src/client/mac/handler/dynamic_images.h,v
retrieving revision 1.1
diff -u -4 -r1.1 dynamic_images.h
--- src/client/mac/handler/dynamic_images.h     7 May 2007 01:03:37 -0000
1.1
+++ src/client/mac/handler/dynamic_images.h     22 May 2007 00:02:15 -0000
@@ -163,9 +163,9 @@
  private:
   friend class DynamicImages;

   // Sanity checking
-  bool IsValid() {return GetVMAddr() != 0;}
+  bool IsValid() {return GetVMSize() != 0;}

   // Makes local copy of file path to mach-o binary
   void InitializeFilePath(char *inFilePath) {
     if (inFilePath) {

Original issue reported on code.google.com by bsmedb...@gmail.com on 22 May 2007 at 12:18

[GoogleCodeExporter]

r=me and checked in at trunk svn revision [220].

Original comment by mmento...@gmail.com on 28 Sep 2007 at 6:31

• Changed state: Fixed
• Added labels: Component-Client-Handler, OpSys-OSX