search

bornintelligent / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Allow building with -pedantic #186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There are a couple of locations were our code is not strictly
standards-conformant.  "g++ -pedantic" complains about our use of
zero-sized arrays, "LL" constant size modifiers (part of C99 but not C++),
and trailing commas in enums.

This patch fixes those problems and allows the processor to compile under
-pedantic.

An additional set of warnings is present at -pedantic (errors with
-pedantic-errors) complaining about our use of "ll" as a printf size
modifier (again, part of C99 but not C++).  We may want to change those, too.

Original issue reported on code.google.com by mmento...@gmail.com on 31 May 2007 at 7:12

GoogleCodeExporter commented 9 years ago 
Oh, yeah, anonymous structs are also flagged under -pedantic - we had them 
inside two
anonymous unions and didn't really use them for anything, they were just history
carried over from the DbgHelp.h implementation.

Original comment by mmento...@gmail.com on 31 May 2007 at 7:17

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch for Linux client-only code - silly extra semicolon.

Original comment by mmento...@gmail.com on 31 May 2007 at 7:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Checked in, trunk revision [183].

Original comment by mmento...@gmail.com on 31 May 2007 at 7:45