breakpad Linux handler doesn't build with compiler built from latest GCC sources

[GoogleCodeExporter]

This is also filed as Mozilla bug 485019:
https://bugzilla.mozilla.org/show_bug.cgi?id=485019

What steps will reproduce the problem?
1. Check out and build the latest GCC sources.  I used r144965, dated
2009-03-19.
2. Try to build breakpad.

The build dies with the following error:

dump_symbols.cc
c++ -o host_dump_symbols.o -c 
-I/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/../..
-I/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux
-I.  -I../../../../../../dist/include  
-I../../../../../../dist/include/breakpad_linux_common
-I/home/jimb/mc/in/obj-bug/dist/include/nspr    
-I/home/jimb/mc/in/obj-bug/dist/sdk/include
-I/home/jimb/mc/in/obj-bug/dist/include/nspr
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:
In function ‘bool<unnamed>::WriteFormat(int, const char*, ...)’:
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:176:
error: ‘vsnprintf’ was not declared in this scope
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:
In function ‘bool<unnamed>::ComputeSizeAndRVA(Elf32_Addr,
<unnamed>::SymbolInfo*)’:
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:487:
error: ‘stderr’ was not declared in this scope
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:487:
error: ‘fprintf’ was not declared in this scope
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:
In function ‘bool<unnamed>::LoadSymbols(Elf32_Ehdr*, 
<unnamed>::SymbolInfo*)’:
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:586:
error: ‘stderr’ was not declared in this scope
/home/jimb/mc/in/toolkit/crashreporter/google-breakpad/src/common/linux/dump_sym
bols.cc:586:
error: ‘fprintf’ was not declared in this scope
make[6]: *** [host_dump_symbols.o] Error 1

The problem is that the breakpad sources use facilities declared in
<cstdio> without actually #including that file.  The attached patch allows
breakpad to build.

Original issue reported on code.google.com by jimbla...@gmail.com on 24 Mar 2009 at 7:33

Attachments:

• breakpad.patch

[GoogleCodeExporter]

Original comment by ted.mielczarek on 24 Mar 2009 at 7:57

• Changed title: breakpad Linux handler doesn't build with compiler built from latest GCC sources

[GoogleCodeExporter]

Committed this patch in revision 321

Original comment by ted.mielczarek on 24 Mar 2009 at 7:58

• Changed state: Fixed