Add PUBLIC support to SourceLineResolver (resolve function names in system libs)

bornintelligent / google-breakpad

Automatically exported from code.google.com/p/google-breakpad

0 stars 0 forks source link

Add PUBLIC support to SourceLineResolver (resolve function names in system libs) #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

In #21's FPO patch, one of the changes to PDBSourceLineWriter has it write
PUBLIC lines for public symbols in code that doesn't have FUNC lines.  This
is most important in Windows debugging information for functions in system
libraries.  The FPO patch has a stub in SourceLineResolver that causes it
to not croak when it hits a PUBLIC line, but the rest of the PUBLIC stuff
needs to be wired up.

Because PUBLIC symbols are addresses only without any indicator of code
size, we'll need to stuff these into something like the old MemAddrMap (but
probably with an interface identical to RangeMap and ContainedRangeMap) and
resolve against PUBLIC symbols in SourceLineResolver::Module::LookupAddress
if address is outside of a known function.

Original issue reported on code.google.com by mmento...@gmail.com on 18 Oct 2006 at 9:09

GoogleCodeExporter commented 9 years ago

Original comment by mmento...@gmail.com on 18 Oct 2006 at 9:11

Changed title: Add PUBLIC support to SourceLineResolver (resolve function names in system libs)

GoogleCodeExporter commented 9 years ago

This is the new AddressMap template class and tests.  I haven't hooked it up in
SourceLineResolver yet because there are other changes to that file going on in 
#21.

Original comment by mmento...@gmail.com on 19 Oct 2006 at 5:49

Attachments:

airbag.53.am.1.patch

GoogleCodeExporter commented 9 years ago

Original comment by mmento...@gmail.com on 20 Oct 2006 at 4:25

Attachments:

airbag.53.1.patch

GoogleCodeExporter commented 9 years ago

Whoops, this should have been included in the patch.  Here are the test changes.

Original comment by mmento...@gmail.com on 20 Oct 2006 at 4:36

Attachments:

airbag.53-test.1.patch

GoogleCodeExporter commented 9 years ago

Addresses review comments and fixes #49 (because it was a couple of extra lines 
of
code to do #49 with the changes made to address the review.)

Original comment by mmento...@gmail.com on 20 Oct 2006 at 7:35

Attachments:

airbag.53.2.patch

GoogleCodeExporter commented 9 years ago

Checked in, revision [43].

Original comment by mmento...@gmail.com on 20 Oct 2006 at 7:56

Changed state: Fixed