borodean / postcss-assets

An asset manager for PostCSS
MIT License
537 stars 32 forks source link

Use PostCSS 4.1 API #20

Closed TrySound closed 9 years ago

TrySound commented 9 years ago

PostCSS Plugin Guidelines are mandatory right now. Because all of rules are about ecosystem health.

borodean commented 9 years ago

Points that postcss-assets is not currently following are:

Am I missing something?

TrySound commented 9 years ago

Test on node 12 or io.js need if you want to use promise API. In your case it should be async, so yes. And do not use fs.exists or fs.existsSync methods, caz it's deprecated.

For now make at least postcss.plugin and postcss-plugin keyword.

ai commented 9 years ago

I think 2 step migration is a best way:

  1. Fixing keyword, postcss.plugin, adding io.js to Travis CI.
  2. Migrate to async methods.
borodean commented 9 years ago

Good plan, @ai.

Fixing keyword, postcss.plugin, adding io.js to Travis CI.

This is now implemented in 2.1.2.

TrySound commented 9 years ago

@borodean Minor release please.

borodean commented 9 years ago

@TrySound why minor? I've added no functionality.

ai commented 9 years ago

BTW, [major].[minor].[patch], so minor is a for public API extending.

borodean commented 9 years ago

@ai I don't think any public API changed in 2.1.2, only the way its made. Am I wrong?

ai commented 9 years ago

@borodean patch is for no API changes. You are right.