search

borowiak / pwa-technologies

Automatically exported from code.google.com/p/pwa-technologies
0 stars 0 forks source link

Inefficient use of keySet iterator instead of entrySet iterator #51

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As reported by Sonar: "This method accesses the value of a Map entry, using a 
key that was retrieved from a keySet iterator. It is more efficient to use an 
iterator on the entrySet of the map, to avoid the Map.get(key) lookup."

The classes with the reported issue are:
* org.archive.wayback.replay.HttpHeaderOperation
* org.archive.wayback.resourcestore.ArcResource
* org.archive.wayback.webapp.RequestMapper

Original issue reported on code.google.com by whisp...@gmail.com on 18 Sep 2012 at 11:17

GoogleCodeExporter commented 9 years ago 
A patch fixing this issue was added.

Special notice: the code in RequestMapper seemed to do the same thing twice and 
was thus simplified.

Original comment by devel.da...@vcruz.net on 18 Sep 2012 at 11:20

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r443.

Original comment by devel.da...@vcruz.net on 29 Nov 2012 at 12:09