Use indexOf(Char) instead of indexOf(String)

[GoogleCodeExporter]

As reported by PMD:
"Use String.indexOf(char) when checking for the index of a single character; it 
executes faster."

Seeing the source code from the String class, one can see the difference in 
code complexity.

Classes with the reported issue:
* org.archive.wayback.accesscontrol.robotstxt.RobotRules
* org.archive.wayback.requestparser.OpenSearchRequestParser
* org.archive.wayback.resourcestore.WARCRecordToSearchResultAdapter
* org.archive.wayback.resourceindex.indexer.RemoteSubmitFilter
* org.archive.wayback.util.url.AggressiveUrlCanonicalizer
* org.archive.wayback.webapp.AccessPoint
* org.archive.wayback.webapp.RequestMapper

Original issue reported on code.google.com by devel.da...@vcruz.net on 24 Sep 2012 at 10:31

[GoogleCodeExporter]

Other classes with the reported issue:
* 
PwaArchive-access/projects/access-control/access-control/src/main/java/org/archi
ve/accesscontrol/AccessControlClient.java
* 
PwaArchive-access/projects/access-control/oracle/src/main/java/org/archive/acces
scontrol/oracle/RulesController.java
* 
PwaArchive-access/projects/access-control/oracle/src/main/java/org/archive/acces
scontrol/webui/AdminController.java
* 
PwaArchive-access/projects/nutchwax/nutchwax-thirdparty/nutch/contrib/web2/plugi
ns/web-query-propose-spellcheck/src/java/org/apache/nutch/spell/NGramSpeller.jav
a
* 
PwaArchive-access/projects/nutchwax/nutchwax-thirdparty/nutch/contrib/web2/src/m
ain/java/org/apache/nutch/webapp/servlet/NutchHttpServlet.java
* 
PwaArchive-access/projects/nutchwax/nutchwax-thirdparty/nutch/contrib/web2/src/m
ain/java/org/apache/nutch/webapp/servlet/ResourceServlet.java
* 
PwaArchive-access/projects/nutchwax/nutchwax-thirdparty/nutch/src/plugin/lib-htt
p/src/java/org/apache/nutch/protocol/http/api/RobotRulesParser.java
* 
PwaArchive-access/projects/nutchwax/nutchwax-thirdparty/nutch/src/plugin/protoco
l-http/src/java/org/apache/nutch/protocol/http/HttpResponse.java
* 
PwaArchive-access/projects/wayback/wayback-core/src/main/java/org/archive/waybac
k/resourceindex/indexer/RemoteSubmitFilter.java
* PwaLogsMiner/src/main/java/pt/arquivo/logs/arquivo/LogAnalyzer.java
* PwaLogsMiner/src/main/java/pt/arquivo/logs/arquivo/UrlDepth.java
* PwaLogsMiner/src/main/java/pt/arquivo/logs/tumba/LogAnalyzer.java
* 
PwaLucene/src/main/java/org/apache/lucene/search/features/queryindependent/PwaUr
lDepth.java
* PwaSpellchecker/src/main/java/pt/arquivo/spellchecker/SpellChecker.java

Original comment by devel.da...@vcruz.net on 24 Sep 2012 at 11:20

[GoogleCodeExporter]

Added patch.

Original comment by devel.da...@vcruz.net on 24 Sep 2012 at 2:15

• Changed state: Patch

Attachments:

• issue-55.patch

[GoogleCodeExporter]

This issue was closed by revision r450.

Original comment by devel.da...@vcruz.net on 21 Dec 2012 at 3:42

• Changed state: Fixed