borysiasty / plugin_reloader

QGIS plugin: Reloads a chosen plugin in one click (only useful for Python Plugin Developers)
GNU General Public License v3.0
19 stars 17 forks source link

Fresh plugin in fresh install tries to load an empty plugin #27

Closed rduivenvoorde closed 2 years ago

rduivenvoorde commented 3 years ago

Not really important because it happens only once :-)

But when you have a fresh install, install another plugin, and the the plugin reloader, Push the Plugin reloader button in the button bar, There is (off course) no plugin selected yet, so the following exception is raised: Would be good to switch to the configuration window when the 'module name' is empty? (OR initiate it with the Plugin Reloader itself?)

2021-10-08T19:11:17     CRITICAL    Traceback (most recent call last):
              File "C:/PROGRA~1/QGIS3~1.16/apps/qgis-ltr/./python\qgis\utils.py", line 312, in loadPlugin
              __import__(packageName)
              File "C:/PROGRA~1/QGIS3~1.16/apps/qgis-ltr/./python\qgis\utils.py", line 793, in _import
              mod = _builtin_import(name, globals, locals, fromlist, level)
             ValueError: Empty module name

Super, super needed plugin by the way!!! Thanks!

jfbourdon commented 3 years ago

Are you saying that the configuration window is not showing up when following the steps you described? On my machine the same error is raised, but the configuration window pops up at the same time.

It might be better to have a more specific message in the message bar for this special case, but a simpler approach would be to initiate the pluginit with itself as you suggest.

borysiasty commented 2 years ago

Hi Richard! Hopefully it's fixed now. A new version is ready for release, just waiting a bit for a possible translaton update.

rduivenvoorde commented 2 years ago

Cool, thanks for taking time! I'll test the next release!

borysiasty commented 2 years ago

Not a problem at all. It's my duty to assure that Mankind and all the Aliens are comfortable with reloading their QGIS plugins ;)

rduivenvoorde commented 2 years ago

Ok, just tested... Closing