search

borysiasty / plugin_reloader

QGIS plugin: Reloads a chosen plugin in one click (only useful for Python Plugin Developers)
GNU General Public License v3.0
19 stars 17 forks source link

Plugin not showing up in QGIS master plugin manager #7

Closed m-kuhn closed 7 years ago

m-kuhn commented 7 years ago

I was about to upgrade the plugin to QGIS 3.0 compatibility when I noticed, that this has already been done (thanks @3nids). However, it doesn't show up in the plugin manager, is this related to the version code (only 2.99, the other plugins I have don't specify a maximum version)? CC @elpaso

elpaso commented 7 years ago

It might be https://github.com/borysiasty/plugin_reloader/blob/master/metadata.txt#L14, see also this: https://github.com/qgis/QGIS-Django/blob/master/qgis-app/plugins/models.py#L497 I think that master now sends version 3.0.

borysiasty commented 7 years ago

Hi @m-kuhn, I can't compile master at the moment, but I believe it still sends 2.99.0 (doesn't it?), so could you please try to set: qgisMinimumVersion=2.99 qgisMaximumVersion=3.99

Maybe there is a bug in the comparison algorithm and the current "2.99.0" is considered > "2.99".

If master is switched to "3.0" we can just set the qgisMinimumVersion to 3.0 and remove qgisMaximumVersion - it will fall back to the default value int(qgisMinimumVersion) + 0.99.

m-kuhn commented 7 years ago

i think if you merge #8 it will work. at least with that one it gets picked up by the plugin manager locally.

borysiasty commented 7 years ago

@m-kuhn I don't understand why it works ;) so I just changed qgisMax to 3.99 and released it as 0.7.1. This way it also won't stop working when QGIS declared version is bumped up to 3.0. Could you please try if it works for you?

m-kuhn commented 7 years ago

Works :tada: Thanks @borysiasty