search

bos / llvm

Haskell bindings to the LLVM compiler infrastructure project.
Other
104 stars 34 forks source link

replace mtl by transformers #62

Open amigalemming opened 11 years ago

amigalemming commented 11 years ago

After our last discussion in the mailing list I have replaced mtl by transformers in llvm-tf. I propose to do the same replacement in 'llvm', too. I have prepared a commit for this purpose, that you may simply pull in: http://code.haskell.org/~thielema/llvm-pull/transformers/

'transformers' does not need any language extensions and does not export identifiers from Control.Monad and other 'base' modules.

NathanHowell commented 11 years ago

Can you fix llvm-base as well? It doesn't make much sense to remove it from one location but not the other.

amigalemming commented 11 years ago

LLVM.ST is now ported to transformers, as well.

cartazio commented 11 years ago

@amigalemming can you please give us a pull request so we can review the code changes etc?

thanks

amigalemming commented 11 years ago

The commit is here: http://code.haskell.org/~thielema/llvm-pull/transformers/ What else do you need?

I found the pull-requests via github very cumbersome (mix of shell and web access, looping javascripts at github, impossibility to remove commits), thus I am using code.haskell.org.

cartazio commented 11 years ago

do you want us to look at the patch or not? If yes, please take the 5 minutes to do a pull request.

look forward to seeing the pull request.

amigalemming commented 11 years ago

Is there a way to fork, making pull requests etc. via command line instead of the broken web interface?

cartazio commented 11 years ago

a cursory google search indicates http://stackoverflow.com/questions/4610530/github-cli-clients which in turn links to a bunch.