Closed hewison-chris closed 2 years ago
Merging #3176 (83fac9e) into v0.x.x (4bd4725) will increase coverage by
59.40%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## v0.x.x #3176 +/- ##
===========================================
+ Coverage 20.13% 79.53% +59.40%
===========================================
Files 64 208 +144
Lines 2881 18689 +15808
===========================================
+ Hits 580 14865 +14285
- Misses 2301 3824 +1523
Flag | Coverage Δ | |
---|---|---|
integration | 16.88% <ø> (-3.25%) |
:arrow_down: |
unittests | 87.33% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
source/agora/consensus/protocol/Nominator.d | 90.85% <100.00%> (ø) |
|
source/scpd/scp/SCPDriver.d | 60.00% <0.00%> (-15.00%) |
:arrow_down: |
source/scpd/scp/SCP.d | 100.00% <0.00%> (ø) |
|
agora/submodules/ocean/src/ocean/core/BitArray.d | ||
source/agora/test/ManyValidators.d | 91.66% <0.00%> (ø) |
|
source/agora/consensus/protocol/Data.d | 100.00% <0.00%> (ø) |
|
source/agora/consensus/data/PreImageInfo.d | 100.00% <0.00%> (ø) |
|
source/agora/consensus/validation/Enrollment.d | 98.90% <0.00%> (ø) |
|
source/agora/node/admin/AdminInterface.d | 50.81% <0.00%> (ø) |
|
source/agora/test/Byzantine.d | 95.83% <0.00%> (ø) |
|
... and 151 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4bd4725...83fac9e. Read the comment docs.
Why does it continually trigger though ?
Why does it continually trigger though ?
It should only log for each block fetched during catchup until the height is for blocks in which the validator has the signatures in memory. If it logs when the validator is active then it is a bug.
This can happen if catching up when previously not enrolled.