bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Fix quorum pre-image unit test #3182

Open hewison-chris opened 2 years ago

hewison-chris commented 2 years ago

This test has often failed recently. See commits for details on fix.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3182 (0a0be38) into v0.x.x (0a0be38) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 0a0be38 differs from pull request most recent head ba7f961. Consider uploading reports for the commit ba7f961 to get more accurate results

@@           Coverage Diff           @@
##           v0.x.x    #3182   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files         165      165           
  Lines       17131    17131           
=======================================
  Hits        15192    15192           
  Misses       1939     1939           
Flag Coverage Δ
integration 39.42% <0.00%> (ø)
unittests 87.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hewison-chris commented 2 years ago

This test is never failing locally so is really hard to fix at the moment.

linked0 commented 2 years ago

This test is never failing locally so is really hard to fix at the moment.

If this fails again on CI even with this change, How about solving this problem with other approaches later.

linked0 commented 2 years ago

But if you think there are any improvements in the test result, it's not bad to merge it.