bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

TransactionPool: Remove TXs in batch queries #3183

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

Speeds up block externalization by a lot. Something like from 40 secs to 80 msecs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3183 (027a225) into v0.x.x (3545940) will increase coverage by 58.66%. The diff coverage is 96.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.x.x    #3183       +/-   ##
===========================================
+ Coverage   20.27%   78.93%   +58.66%     
===========================================
  Files          64      210      +146     
  Lines        2881    19002    +16121     
===========================================
+ Hits          584    14999    +14415     
- Misses       2297     4003     +1706     
Flag Coverage Δ
integration 23.42% <ø> (+3.15%) :arrow_up:
unittests 87.32% <96.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/pool/Transaction.d 93.89% <96.42%> (ø)
source/agora/consensus/Ledger.d 97.49% <100.00%> (ø)
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) :arrow_down:
source/scpd/scp/SCP.d 100.00% <0.00%> (ø)
source/agora/test/Restart.d 93.18% <0.00%> (ø)
source/agora/flash/Invoice.d 100.00% <0.00%> (ø)
source/agora/consensus/data/Params.d 43.75% <0.00%> (ø)
source/agora/test/Ledger.d 95.55% <0.00%> (ø)
source/agora/test/ValidatorCount.d 87.50% <0.00%> (ø)
source/agora/script/Script.d 100.00% <0.00%> (ø)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3545940...027a225. Read the comment docs.

omerfirmak commented 2 years ago

macOS green