bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Make TimePoint a struct instead of an alias #3184

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

Had this diff locally since forever. Ideally we'll make it contain a DateTime as well but there are a few obstacles to that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3184 (3cadc33) into v0.x.x (56812ad) will decrease coverage by 7.48%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3184      +/-   ##
==========================================
- Coverage   27.75%   20.27%   -7.49%     
==========================================
  Files         302       64     -238     
  Lines       28933     2881   -26052     
==========================================
- Hits         8031      584    -7447     
+ Misses      20902     2297   -18605     
Flag Coverage Δ
integration 20.27% <ø> (-7.49%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/common/BanManager.d
source/agora/common/Types.d
source/agora/consensus/data/Params.d
source/agora/consensus/protocol/Nominator.d
source/agora/consensus/state/Ledger.d
source/agora/network/Clock.d
source/agora/network/Manager.d
source/agora/node/Config.d
source/agora/node/TransactionRelayer.d
source/agora/node/admin/AdminInterface.d
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56812ad...3cadc33. Read the comment docs.