Potential signature count without side effects

[hewison-chris]

This was not only causing misleading log lines but could have other undesirable side effects.

[codecov[bot]]

Codecov Report

Merging #3188 (ca5f8fd) into v0.x.x (f5b71e0) will decrease coverage by 1.73%. The diff coverage is n/a.

:exclamation: Current head ca5f8fd differs from pull request most recent head 9787986. Consider uploading reports for the commit 9787986 to get more accurate results

@@            Coverage Diff             @@
##           v0.x.x    #3188      +/-   ##
==========================================
- Coverage   19.76%   18.03%   -1.74%     
==========================================
  Files          55       37      -18     
  Lines        2413     1913     -500     
==========================================
- Hits          477      345     -132     
+ Misses       1936     1568     -368     

Flag	Coverage Δ
integration	18.03% <ø> (-1.74%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...odules/ocean/src/ocean/core/ExceptionDefinitions.d
agora/submodules/ocean/src/ocean/core/Exception.d
source/scpd/Cpp.d
source/scpd/scp/SCPDriver.d
source/scpd/types/Utils.d
...gora/submodules/ocean/src/ocean/core/TypeConvert.d
agora/submodules/ocean/src/ocean/core/Test.d
source/scpd/quorum/QuorumIntersectionChecker.d
source/scpd/scp/SCP.d
source/scpd/types/XDRBase.d
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5b71e0...9787986. Read the comment docs.

[hewison-chris]

Module tests failed: agora.test.DNS
core.exception.AssertError@source/agora/test/DNS.d(73): 15 != 14

with trace logging gives (note the NS record which makes the count one more):

2022-03-15 12:21:08,804 Trace [agora.node.Registry] - Fullfilled DNS query: { header: ID: f006 QUERY rd NoError, Query: 1, Answer: 0, Authority: 0, Additional: 1, questions: [{ qname: validators.unittest.bosagora.io., qtype: const(QTYPE).AXFR, qclass: const(QCLASS).IN }], answers: [], authorities: [], additionals: [OPT (payload: 4096)] } => { header: ID: f006 QUERY qr aa rd NoError, Query: 1,  
Answer: 15, Authority: 0, Additional: 0, questions: [{ qname: validators.unittest.bosagora.io., qtype: QTYPE.AXFR, qclass: QCLASS.IN }], answers: [
 name: validators.unittest.bosagora.io., TYPE: SOA, RDATA: const(SOA)(name.registry., test.testnet., 1647314474, 2, 10, 6000, 120), 
 name: boa1xrval5rzmma29zh4aqgv3mvcarhwa0w8rgthy3l9vaj3fywf9894ycmjkm8.validators.unittest.bosagora.io., TYPE: A, RDATA: 0.0.0.10, 
 name: _agora._tcp.boa1xrval5rzmma29zh4aqgv3mvcarhwa0w8rgthy3l9vaj3fywf9894ycmjkm8.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.0/), 
 name: boa1xrval6hd8szdektyz69fnqjwqfejhu4rvrpwlahh9rhaazzpvs5g6lh34l5.validators.unittest.bosagora.io., TYPE: A, RDATA: 3.0.0.10, 
 name: _agora._tcp.boa1xrval6hd8szdektyz69fnqjwqfejhu4rvrpwlahh9rhaazzpvs5g6lh34l5.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.3/), 
 name: boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh.validators.unittest.bosagora.io., TYPE: A, RDATA: 2.0.0.10, 
 name: _agora._tcp.boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.2/), 
 name: boa1xzval2a3cdxv28n6slr62wlczslk3juvk7cu05qt3z55ty2rlfqfc6egsh2.validators.unittest.bosagora.io., TYPE: A, RDATA: 5.0.0.10, 
 name: _agora._tcp.boa1xzval2a3cdxv28n6slr62wlczslk3juvk7cu05qt3z55ty2rlfqfc6egsh2.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.5/), 
 name: boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n.validators.unittest.bosagora.io., TYPE: A, RDATA: 1.0.0.10, 
 name: _agora._tcp.boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.1/), 
 name: boa1xzval4nvru2ej9m0rptq7hatukkavemryvct4f8smyy3ky9ct5u0s8w6gfy.validators.unittest.bosagora.io., TYPE: A, RDATA: 4.0.0.10, 
 name: _agora._tcp.boa1xzval4nvru2ej9m0rptq7hatukkavemryvct4f8smyy3ky9ct5u0s8w6gfy.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.4/), 
 name: validators.unittest.bosagora.io., TYPE: NS, RDATA: name.registry., 
 name: validators.unittest.bosagora.io., TYPE: SOA, RDATA: const(SOA)(name.registry., test.testnet., 1647314474, 2, 10, 6000, 120)], authorities: [], additionals: [] }