bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Add signature to block in edge case #3190

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

If we receive a signature that we have in memory but it is not in the header yet we need to still add it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3190 (ce876b2) into v0.x.x (f5b71e0) will increase coverage by 1.38%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3190      +/-   ##
==========================================
+ Coverage   79.07%   80.45%   +1.38%     
==========================================
  Files         209      198      -11     
  Lines       18929    18613     -316     
==========================================
+ Hits        14968    14975       +7     
+ Misses       3961     3638     -323     
Flag Coverage Δ
integration 18.41% <ø> (-1.35%) :arrow_down:
unittests 87.39% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 92.11% <100.00%> (+0.44%) :arrow_up:
source/agora/script/Engine.d 97.59% <0.00%> (-0.16%) :arrow_down:
source/agora/test/Flash.d 95.12% <0.00%> (-0.11%) :arrow_down:
...ora/submodules/ocean/src/ocean/core/array/Search.d
...gora/submodules/ocean/src/ocean/core/TypeConvert.d
agora/submodules/ocean/src/ocean/core/Verify.d
agora/submodules/ocean/src/ocean/core/Test.d
agora/submodules/ocean/src/ocean/core/Buffer.d
...a/submodules/ocean/src/ocean/core/array/Mutation.d
agora/submodules/ocean/src/ocean/core/Exception.d
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5b71e0...ce876b2. Read the comment docs.