bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Increase SCP slot timeout #3191

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

Our timeouts were a bit agressive for a globally distributed arbitrarily large network. Let's see if this will help decrease our externalization time for the current state of the production.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3191 (0420837) into v0.x.x (2d4c94b) will increase coverage by 34.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.x.x    #3191       +/-   ##
===========================================
+ Coverage   17.87%   52.04%   +34.16%     
===========================================
  Files          64      368      +304     
  Lines        2881    37570    +34689     
===========================================
+ Hits          515    19553    +19038     
- Misses       2366    18017    +15651     
Flag Coverage Δ
integration 27.92% <100.00%> (+10.04%) :arrow_up:
unittests 87.39% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 92.05% <100.00%> (ø)
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) :arrow_down:
source/scpd/scp/SCP.d 100.00% <0.00%> (ø)
agora/submodules/vibe.d/http/vibe/http/dist.d 0.00% <0.00%> (ø)
source/agora/consensus/data/genesis/Coinnet.d 100.00% <0.00%> (ø)
...ora/submodules/configy/source/configy/Attributes.d 100.00% <0.00%> (ø)
...ra/submodules/vibe.d/utils/vibe/utils/validation.d 0.00% <0.00%> (ø)
agora/submodules/vibe.d/http/vibe/http/common.d 8.57% <0.00%> (ø)
agora/submodules/dyaml/source/dyaml/composer.d 63.79% <0.00%> (ø)
...a/submodules/vibe-core/source/vibe/internal/list.d 67.24% <0.00%> (ø)
... and 309 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d4c94b...0420837. Read the comment docs.

hewison-chris commented 2 years ago

Integration test restarted as it failed.