bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Quorum: Ensure we maintain majority in threshold calculations #3192

Closed omerfirmak closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #3192 (e41c81e) into v0.x.x (f5b71e0) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3192      +/-   ##
==========================================
+ Coverage   79.07%   79.11%   +0.03%     
==========================================
  Files         209      209              
  Lines       18929    18940      +11     
==========================================
+ Hits        14968    14984      +16     
+ Misses       3961     3956       -5     
Flag Coverage Δ
integration 20.27% <ø> (+0.50%) :arrow_up:
unittests 87.29% <100.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/Quorum.d 97.09% <100.00%> (+0.01%) :arrow_up:
source/agora/consensus/data/Params.d 47.05% <100.00%> (+3.30%) :arrow_up:
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) :arrow_down:
source/agora/network/Client.d 82.44% <0.00%> (-4.59%) :arrow_down:
source/agora/network/Manager.d 78.96% <0.00%> (-1.30%) :arrow_down:
source/agora/script/Engine.d 97.59% <0.00%> (-0.16%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 91.80% <0.00%> (+0.14%) :arrow_up:
source/agora/flash/Node.d 80.88% <0.00%> (+0.21%) :arrow_up:
source/agora/node/Validator.d 91.19% <0.00%> (+0.42%) :arrow_up:
source/agora/utils/Log.d 58.94% <0.00%> (+10.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5b71e0...e41c81e. Read the comment docs.