bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Skip last section of QuorumPreimage test #3195

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

We should at least do this until it is fixed as now we merge with only subset of tests running which is worse than skipping this last check in QuorumPreimage test.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3195 (eaf1bef) into v0.x.x (82f81d5) will increase coverage by 11.07%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.x.x    #3195       +/-   ##
===========================================
+ Coverage   15.72%   26.79%   +11.07%     
===========================================
  Files          48      104       +56     
  Lines        2220     7479     +5259     
===========================================
+ Hits          349     2004     +1655     
- Misses       1871     5475     +3604     
Flag Coverage Δ
integration 26.79% <ø> (+11.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/flash/UpdateSigner.d 0.00% <0.00%> (ø)
source/agora/crypto/Bech32.d 92.13% <0.00%> (ø)
source/agora/crypto/Crc16.d 100.00% <0.00%> (ø)
source/agora/node/Config.d 37.09% <0.00%> (ø)
source/agora/network/Client.d 75.57% <0.00%> (ø)
source/scpd/quorum/QuorumTracker.d 0.00% <0.00%> (ø)
source/agora/node/TransactionRelayer.d 77.27% <0.00%> (ø)
source/agora/network/Manager.d 70.22% <0.00%> (ø)
source/scpd/scp/SCPDriver.d 75.00% <0.00%> (ø)
source/agora/utils/InetUtils.d 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82f81d5...eaf1bef. Read the comment docs.

hewison-chris commented 2 years ago

MacOS is green