bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

UnlockAge test: use 2 test validators #3196

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

No need to test with more than two as we are verifying the transaction input unlock not consensus. It could even be just one but that would require a bit more test refactorring as currently it fails to set up test network in unit tests if only a single validator is used.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3196 (7a30c34) into v0.x.x (db94d66) will increase coverage by 4.35%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3196      +/-   ##
==========================================
+ Coverage   15.91%   20.27%   +4.35%     
==========================================
  Files          46       64      +18     
  Lines        2193     2881     +688     
==========================================
+ Hits          349      584     +235     
- Misses       1844     2297     +453     
Flag Coverage Δ
integration 20.27% <ø> (+4.35%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/scpd/quorum/QuorumTracker.d 0.00% <0.00%> (ø)
source/agora/utils/Test.d 0.00% <0.00%> (ø)
source/scpd/scp/SCPDriver.d 75.00% <0.00%> (ø)
source/agora/utils/InetUtils.d 0.00% <0.00%> (ø)
source/agora/utils/Log.d 43.63% <0.00%> (ø)
source/agora/utils/Utility.d 0.00% <0.00%> (ø)
source/scpd/Cpp.d 58.62% <0.00%> (ø)
source/scpd/types/Stellar_SCP.d 62.18% <0.00%> (ø)
source/agora/utils/SCPPrettyPrinter.d 8.92% <0.00%> (ø)
source/scpd/scp/SCP.d 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db94d66...7a30c34. Read the comment docs.

hewison-chris commented 2 years ago

UnlockAge test passed which this is fixing so will merge this.