search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

DNS unit test failure #3197

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago 
Module tests failed: agora.test.DNS
core.exception.AssertError@source/agora/test/DNS.d(73): 15 != 14

with trace logging gives (note the NS record which makes the count one more):

2022-03-15 12:21:08,804 Trace [agora.node.Registry] - Fullfilled DNS query: { header: ID: f006 QUERY rd NoError, Query: 1, Answer: 0, Authority: 0, Additional: 1, questions: [{ qname: validators.unittest.bosagora.io., qtype: const(QTYPE).AXFR, qclass: const(QCLASS).IN }], answers: [], authorities: [], additionals: [OPT (payload: 4096)] } => { header: ID: f006 QUERY qr aa rd NoError, Query: 1,  
Answer: 15, Authority: 0, Additional: 0, questions: [{ qname: validators.unittest.bosagora.io., qtype: QTYPE.AXFR, qclass: QCLASS.IN }], answers: [
 name: validators.unittest.bosagora.io., TYPE: SOA, RDATA: const(SOA)(name.registry., test.testnet., 1647314474, 2, 10, 6000, 120), 
 name: boa1xrval5rzmma29zh4aqgv3mvcarhwa0w8rgthy3l9vaj3fywf9894ycmjkm8.validators.unittest.bosagora.io., TYPE: A, RDATA: 0.0.0.10, 
 name: _agora._tcp.boa1xrval5rzmma29zh4aqgv3mvcarhwa0w8rgthy3l9vaj3fywf9894ycmjkm8.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.0/), 
 name: boa1xrval6hd8szdektyz69fnqjwqfejhu4rvrpwlahh9rhaazzpvs5g6lh34l5.validators.unittest.bosagora.io., TYPE: A, RDATA: 3.0.0.10, 
 name: _agora._tcp.boa1xrval6hd8szdektyz69fnqjwqfejhu4rvrpwlahh9rhaazzpvs5g6lh34l5.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.3/), 
 name: boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh.validators.unittest.bosagora.io., TYPE: A, RDATA: 2.0.0.10, 
 name: _agora._tcp.boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.2/), 
 name: boa1xzval2a3cdxv28n6slr62wlczslk3juvk7cu05qt3z55ty2rlfqfc6egsh2.validators.unittest.bosagora.io., TYPE: A, RDATA: 5.0.0.10, 
 name: _agora._tcp.boa1xzval2a3cdxv28n6slr62wlczslk3juvk7cu05qt3z55ty2rlfqfc6egsh2.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.5/), 
 name: boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n.validators.unittest.bosagora.io., TYPE: A, RDATA: 1.0.0.10, 
 name: _agora._tcp.boa1xzval3ah8z7ewhuzx6mywveyr79f24w49rdypwgurhjkr8z2ke2mycftv9n.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.1/), 
 name: boa1xzval4nvru2ej9m0rptq7hatukkavemryvct4f8smyy3ky9ct5u0s8w6gfy.validators.unittest.bosagora.io., TYPE: A, RDATA: 4.0.0.10, 
 name: _agora._tcp.boa1xzval4nvru2ej9m0rptq7hatukkavemryvct4f8smyy3ky9ct5u0s8w6gfy.validators.unittest.bosagora.io., TYPE: URI, RDATA: const(URIRDATA)(0, 0, agora://10.0.0.4/), 
 name: validators.unittest.bosagora.io., TYPE: NS, RDATA: name.registry., 
 name: validators.unittest.bosagora.io., TYPE: SOA, RDATA: const(SOA)(name.registry., test.testnet., 1647314474, 2, 10, 6000, 120)], authorities: [], additionals: [] }

Originally posted by @hewison-chris in https://github.com/bosagora/agora/issues/3188#issuecomment-1067528972

mkykadir commented 2 years ago

3118 caused that, AXFR now should include NS records also

hewison-chris commented 2 years ago

3118 caused that, AXFR now should include NS records also

~It is not always included though.~ Because it wasn't getting to that test of course.