bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Test: Fix DNS AXFR test condition to include NS record #3198

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

PR #3118 includes a fix that allows NS records to be transferred with AXFR query but test update was missing.

Fixes #3197

codecov[bot] commented 2 years ago

Codecov Report

Merging #3198 (c2e310e) into v0.x.x (b947ae2) will increase coverage by 62.86%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.x.x    #3198       +/-   ##
===========================================
+ Coverage   16.26%   79.12%   +62.86%     
===========================================
  Files          48      209      +161     
  Lines        2220    18931    +16711     
===========================================
+ Hits          361    14980    +14619     
- Misses       1859     3951     +2092     
Flag Coverage Δ
integration 19.76% <ø> (+3.50%) :arrow_up:
unittests 87.41% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/DNS.d 96.59% <100.00%> (ø)
source/agora/test/QuorumPreimage.d 76.47% <0.00%> (ø)
tests/unit/BlockStorageMultiTx.d 100.00% <0.00%> (ø)
tests/unit/BlockStorage.d 100.00% <0.00%> (ø)
source/agora/test/PeriodicCatchup.d 96.29% <0.00%> (ø)
source/agora/test/MultiRoundConsensus.d 95.23% <0.00%> (ø)
source/agora/node/Config.d 69.42% <0.00%> (ø)
source/agora/test/EmptyBlocks.d 91.66% <0.00%> (ø)
source/agora/script/Opcodes.d 100.00% <0.00%> (ø)
source/scpd/types/Stellar_SCP.d 68.99% <0.00%> (ø)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b947ae2...c2e310e. Read the comment docs.

Geod24 commented 2 years ago

💚