search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

FullNode: `acceptHeader` is never invoked for missing block signature updates #3199

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

https://github.com/bosagora/agora/blob/b947ae2e0b2188a662b74dc9de2beea7d522a26b/source/agora/network/Manager.d#L993-L994

potential signature count is equal to signature count for a (just) FullNode since extra_sigs is just returning 0; thus acceptHeader can never be invoked.

https://github.com/bosagora/agora/blob/b947ae2e0b2188a662b74dc9de2beea7d522a26b/source/agora/node/FullNode.d#L605

mkykadir commented 2 years ago

It will be invoked when it finds header from another peer with full signature.

hewison-chris commented 2 years ago

It will be invoked when it finds header from another peer with full signature.

Or more than it had.