bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Delay forcing catchup till end of block time #3200

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

To help prevent the blockchain flat lining a check was added to nominate function to resend latest envelopes and kick off catchup task after 10 msecs. This is better left till the time has been reached for the next block start rather than the current. Otherwise catchup will keep the node busy whilst others are nominating.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3200 (6d2cddc) into v0.x.x (6e3a0e7) will increase coverage by 0.05%. The diff coverage is 100.00%.

:exclamation: Current head 6d2cddc differs from pull request most recent head 70e1da7. Consider uploading reports for the commit 70e1da7 to get more accurate results

@@            Coverage Diff             @@
##           v0.x.x    #3200      +/-   ##
==========================================
+ Coverage   87.32%   87.38%   +0.05%     
==========================================
  Files         163      163              
  Lines       16760    16760              
==========================================
+ Hits        14636    14646      +10     
+ Misses       2124     2114      -10     
Flag Coverage Δ
unittests 87.38% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 91.87% <100.00%> (-0.38%) :arrow_down:
source/agora/test/NetworkDiscovery.d 84.09% <0.00%> (-4.55%) :arrow_down:
source/agora/node/FullNode.d 73.63% <0.00%> (+0.30%) :arrow_up:
source/agora/consensus/state/Ledger.d 90.74% <0.00%> (+0.35%) :arrow_up:
source/agora/flash/Node.d 81.09% <0.00%> (+0.42%) :arrow_up:
source/agora/network/Manager.d 80.25% <0.00%> (+1.29%) :arrow_up:
source/agora/network/Client.d 87.02% <0.00%> (+4.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e3a0e7...70e1da7. Read the comment docs.

linked0 commented 2 years ago

Re-running as I'm waiting for it. :)