bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Collect statistics in Nominator #3204

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

could help us track health status of the consensus

codecov[bot] commented 2 years ago

Codecov Report

Merging #3204 (79f9265) into v0.x.x (d2b6dec) will decrease coverage by 35.11%. The diff coverage is 90.47%.

@@             Coverage Diff             @@
##           v0.x.x    #3204       +/-   ##
===========================================
- Coverage   87.36%   52.24%   -35.12%     
===========================================
  Files         163      371      +208     
  Lines       16789    37757    +20968     
===========================================
+ Hits        14668    19728     +5060     
- Misses       2121    18029    +15908     
Flag Coverage Δ
integration 27.75% <90.47%> (?)
unittests 87.48% <90.47%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 91.51% <86.66%> (+0.19%) :arrow_up:
source/agora/consensus/state/Ledger.d 90.60% <100.00%> (-0.31%) :arrow_down:
source/agora/stats/Stats.d 100.00% <100.00%> (ø)
source/agora/stats/Utils.d 100.00% <0.00%> (ø)
source/agora/script/Signature.d 100.00% <0.00%> (ø)
source/agora/utils/SCPPrettyPrinter.d 91.72% <0.00%> (ø)
source/agora/node/admin/AdminInterface.d 52.54% <0.00%> (ø)
agora/submodules/ocean/src/ocean/core/Enforce.d 0.00% <0.00%> (ø)
... and 225 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2b6dec...79f9265. Read the comment docs.

Geod24 commented 2 years ago

This failed integration three times in a row. Triggering a 4th time but there may be something wrong ?

omerfirmak commented 2 years ago

This failed integration three times in a row. Triggering a 4th time but there may be something wrong ?

Green, I will give it another try locally and merge if it looks good.