bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Internalize Prometheus dependencies #3207

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

As mentioned recently, I am attempting to drop our Ocean dependency, and besides the formatter / logger, Prometheus is the only thing we use from it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3207 (621473b) into v0.x.x (82f81d5) will increase coverage by 63.59%. The diff coverage is 99.17%.

@@             Coverage Diff             @@
##           v0.x.x    #3207       +/-   ##
===========================================
+ Coverage   15.72%   79.31%   +63.59%     
===========================================
  Files          48      212      +164     
  Lines        2220    19101    +16881     
===========================================
+ Hits          349    15150    +14801     
- Misses       1871     3951     +2080     
Flag Coverage Δ
integration 20.14% <ø> (+4.42%) :arrow_up:
unittests 87.45% <99.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/node/admin/AdminInterface.d 52.54% <ø> (ø)
source/agora/script/Signature.d 100.00% <ø> (ø)
source/agora/stats/Server.d 0.00% <ø> (ø)
source/agora/stats/Stats.d 100.00% <ø> (ø)
source/agora/stats/Utils.d 100.00% <ø> (ø)
source/agora/utils/SCPPrettyPrinter.d 91.72% <ø> (ø)
source/agora/stats/CollectorRegistry.d 96.66% <96.66%> (ø)
source/agora/stats/Collector.d 100.00% <100.00%> (ø)
source/agora/stats/StatFormatter.d 100.00% <100.00%> (ø)
...cean/util/prometheus/collector/CollectorRegistry.d 0.00% <0.00%> (-44.45%) :arrow_down:
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82f81d5...621473b. Read the comment docs.